This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Upgraded minimatch to remove security vulnerability & other dep upgrades#64
Open
yogeshgadge wants to merge 4 commits intoharthur:masterfrom
Open
Upgraded minimatch to remove security vulnerability & other dep upgrades#64yogeshgadge wants to merge 4 commits intoharthur:masterfrom
yogeshgadge wants to merge 4 commits intoharthur:masterfrom
Conversation
added 4 commits
July 18, 2017 18:56
yogeshgadge
changed the title
Author
|
@harthur Do you need us to reflect the no version number in the PR? |
|
@yogeshgadge I published your changes in a separated fork from harthur/replace: |
|
@harthur Could you update the npm package with this PR merged? Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of minimatch was reported as a security vulnerability by
https://snyk.io/vuln/npm:minimatch:20160620?utm_source=bithound
Fixed these dependencies.
Noticed that test_numbers.txt was missing.
And the tests were not OS independent.
Had to fix these tests before upgrade to ensure the tests pass both before and after.